1. Welcome to LilyPad. Download the project, explore the forums, and create your own LilyPad network.


    If you use the software and enjoy it or have a question, or would like to contribute to the future of the software directly or through resources, please sign up and join our little community.

Resolved Network IP

Discussion in 'Bug Reports' started by confuser, Sep 14, 2013.

  1. confuser

    confuser Member Resource Contributor

    Just updated to the latest Bukkit-Connect build on all my servers. My plugin, BanManager stores IP's of players when they join via the async login event. It seems now that it logs all players ips with the lilypad ip and not there actual IP.

    Please advise.
    confuser, Sep 14, 2013
    #1
  2. Coelho

    Coelho Software Engineer Staff Member Administrator Maintainer

    This will be investigated.
    Coelho, Sep 14, 2013
    #2
  3. confuser

    confuser Member Resource Contributor

    Any luck? It's a pretty serious bug for all using BanManager with LilyPad. If there's anything I need to change on my end, let me know.
    confuser, Sep 18, 2013
    #3
  4. Coelho

    Coelho Software Engineer Staff Member Administrator Maintainer

    Upon testing LilyPad with BanManager I did not receive the proxy IP but rather the user's IP.

    Not only this, but an AsyncLoginEvent doesn't exist.
    Coelho, Sep 25, 2013
    #4
  5. confuser

    confuser Member Resource Contributor

    Last edited: Sep 26, 2013
    confuser, Sep 25, 2013
    #5
  6. confuser

    confuser Member Resource Contributor

    @Coelho this is still a major issue causing chat spam. This is not an invalid bug. Reverting to an older bukkit connect version that forces servers into offline mode does not have this issue.
    confuser, Sep 26, 2013
    #6
    • Agree Agree x 1
  7. Coelho

    Coelho Software Engineer Staff Member Administrator Maintainer

    Please listen on PlayerLoginEvent, NOT PlayerPreLoginEvent.
    Coelho, Sep 28, 2013
    #7
  8. confuser

    confuser Member Resource Contributor

    There is no async player login event, only pre. I've been using that same code for over a year. Only your latest builds break it because they no longer force servers into offline mode which doesn't fire that event.
    confuser, Sep 29, 2013
    #8
  9. Coelho

    Coelho Software Engineer Staff Member Administrator Maintainer

    We are indeed forcing the server into offline mode. Perhaps the way you are checking if it is in offline mode is broken somehow?

    Be aware that LilyPad forces into offline mode one tick after onEnable.
    Coelho, Sep 29, 2013
    #9
  10. confuser

    confuser Member Resource Contributor

    So even if I were to soft depend on lilypad, it would still have the same issues? At what point do you correct the ip?
    confuser, Sep 29, 2013
    #10
  11. Coelho

    Coelho Software Engineer Staff Member Administrator Maintainer

    We correct the IP in the PlayerLoginEvent.
    Coelho, Sep 30, 2013
    #11
  12. Alex Markey

    Alex Markey New Member

    Alex Markey, Oct 3, 2013
    #12
  13. confuser

    confuser Member Resource Contributor

    I'll make a change this weekend to set the ip within the player login event, priority monitor. That should solve it once and for all.
    confuser, Oct 3, 2013
    #13
  14. confuser

    confuser Member Resource Contributor

    This has been resolved as of BanManager v3.13
    confuser, Oct 6, 2013
    #14
    • Like Like x 1

Share This Page